Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][IMP] tracking_manager: add field type html support #3175

Merged
merged 1 commit into from
Feb 8, 2025
Merged

[17.0][IMP] tracking_manager: add field type html support #3175

merged 1 commit into from
Feb 8, 2025

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Jan 24, 2025

tracking_manager enables the user to activate tracking on html fields. This leads to an error message:
image

@OCA-git-bot
Copy link
Contributor

Hi @sebastienbeau, @Kev-Roche,
some modules you are maintaining are being modified, check this out!

@CRogos CRogos mentioned this pull request Jan 24, 2025
Open
MohamedOsman7
MohamedOsman7 approved these changes Jan 27, 2025
View reviewed changes
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fb-ife
fb-ife reviewed Jan 31, 2025
View reviewed changes
Copy link

@fb-ife fb-ife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CRogos I think you need to update the readme file by incresing the version and add the history of your changes

@CRogos
Copy link
Contributor Author

CRogos commented Jan 31, 2025

@fb-ife regarding the version change I am 100% sure that this is automatically changed by the bot/ci.

Adding some description to a history is also new to my. Aren't the git commits the history? If you are think I am wrong I need a little bit more guidance where to change.
I could have add me to the contributor list, but I am doing this already on this PR #3176

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor Author

CRogos commented Feb 8, 2025

@pedrobaeza could you merge and maybe have a look into #3176

@pedrobaeza pedrobaeza added this to the 17.0 milestone Feb 8, 2025
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3175-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7d8fd6e. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 0dd12f1 into OCA:17.0 Feb 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

@fb-ife fb-ife fb-ife approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CRogos @OCA-git-bot @pedrobaeza @MohamedOsman7 @fb-ife